[wp-trac] [WordPress Trac] #40951: New Text Widget - Switching Between Visual/Text Editor Strips Out Code

[WordPress Trac]

#40951: New Text Widget - Switching Between Visual/Text Editor Strips Out Code
-------------------------------------------------+-------------------------
 Reporter:  dwrippe                              |       Owner:
     Type:  defect (bug)                         |  westonruter
 Priority:  normal                               |      Status:  reopened
Component:  Widgets                              |   Milestone:  4.8.1
 Severity:  major                                |     Version:  4.8
 Keywords:  needs-testing has-unit-tests has-    |  Resolution:
  patch commit fixed-major                       |     Focuses:
-------------------------------------------------+-------------------------
Changes (by bobbingwide):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Comments on the new Custom HTML code... having tested the new solution for
 #40993.

 1. I don't understand why is_legacy_instance() is called during
 wp_list_widgets() processing. Note: It doesn't cause a problem at present.

 2. I think that the message that says 'This widget contains code that may
 work better in the new “Custom HTML” widget. How about trying that widget
 instead?' doesn't need the word 'new'. Some time in the future new will be
 old.

 3. When the widget text contains a shortcode then it may not work better
 in the Custom HTML widget as do_shortcode is not automatically attached to
 'widget_custom_html_content'. So, until logic is added to enable shortcode
 processing it'll be worse.

 4. The message doesn't go away even when the widget has been changed.
 So perhaps the message should say 'This widget may contain code...'.

 5. And what's meant by 'code' anyway. Some users may think it's the code
 tag(s) created by the code button.

 6. Checking for the presence of a shortcode assumes that the shortcode has
 been registered. Not all shortcodes are registered during admin
 processing. Sometimes shortcodes are inactive since the plugins to which
 they're associated have been deactivated.

 7. Does the presence of shortcodes matter anyway, now that there's just in
 time processing?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40951#comment:136>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform