[wp-trac] [WordPress Trac] #40966: Double clicking the Update plugins-button gives... interesting experience!

WordPress Trac noreply at wordpress.org
Sat Jul 15 19:08:15 UTC 2017


#40966: Double clicking the Update plugins-button gives... interesting experience!
-------------------------------------------------+-------------------------
 Reporter:  bitnissen                            |       Owner:  swissspidy
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
Component:  Upgrade/Install                      |  Release
 Severity:  normal                               |     Version:  4.6
 Keywords:  shiny-updates good-first-bug has-    |  Resolution:
  patch                                          |     Focuses:
-------------------------------------------------+-------------------------

Comment (by swissspidy):

 Few notes:

 * Network admin for themes is probably affected too
 * The first patches don't work because of a11y rasons
 * [attachment:40966.4.diff] is too broad. `$('.updating-message')` could
 be anything

 What we really need is a way to disallow a specific theme/plugin that has
 already been updated.

 The bulk action handler bails early if an item doesn't have the `update`
 class (like, when a plugin doesn't have an update). In theory this be used
 to fix this bug here. However, `wp.updates.updatePlugin` doesn't remove
 that `update` class after a successful update.

 [attachment:40966.5.diff] fixes that by removing `update` with `updating`
 during the process.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40966#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list