[wp-trac] [WordPress Trac] #40503: Use get_network_option in wpmu_create_blog

[WordPress Trac]

#40503: Use get_network_option in wpmu_create_blog
--------------------------------------+------------------------
 Reporter:  spacedmonkey              |       Owner:  flixos90
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  4.9
Component:  Networks and Sites        |     Version:  3.0
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+------------------------

Comment (by flixos90):

 [attachment:40503.3.diff] is a tiny update on the previous patch.

 Having a second look, I think it doesn't make much sense to change the
 `$site_id` to `$network_id` here, since there is still `$blog_id` around,
 and having a function with `$blog_id` and `$network_id` is worse in my
 opinion. It would also be strange to rename `$blog_id` to `$site_id` since
 the function would still have "blog" in the name.

 The rename here is not worth the changeset clutter, although I generally
 like the idea of doing such changes. Given that we're working on a better
 implementation of a similar method anyway (see #40364), I think we can
 leave things as they are for now.

 I only changed a bit of documentation to use the correct "Site" and
 "Network" terms there.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40503#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform