[wp-trac] [WordPress Trac] #41299: oEmbed proxy fails to forward maxwidth and maxheight params

[WordPress Trac]

#41299: oEmbed proxy fails to forward maxwidth and maxheight params
---------------------------------------------+------------------------
 Reporter:  westonruter                      |       Owner:  jnylen0
     Type:  defect (bug)                     |      Status:  reviewing
 Priority:  normal                           |   Milestone:  4.8.1
Component:  Embeds                           |     Version:  4.8
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:  rest-api
---------------------------------------------+------------------------

Comment (by jnylen0):

 Sorry, I just saw that you pinged me for review here.  Code looks good and
 fixes the related Gutenberg issue mentioned in the OP.  I tested as
 follows:

 - Added the `?maxwidth=` parameter in the Gutenberg code
 - Loaded various embeds without this patch
 - Before loading each embed, clear the cached results by running `foreach
 ( $wpdb->get_results("SELECT option_name FROM $wpdb->options WHERE
 option_name LIKE '_transient%oembed%'") as $row ) { error_log(
 $row->option_name ); delete_option( $row->option_name ); }` in `wp shell`

 +1 for commit.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41299#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform