[wp-trac] [WordPress Trac] #35293: Emoji Regex in wp_encode_emoji() is wildly inaccurate

WordPress Trac noreply at wordpress.org
Fri Jul 14 12:44:51 UTC 2017


#35293: Emoji Regex in wp_encode_emoji() is wildly inaccurate
-----------------------------------+-----------------------
 Reporter:  pento                  |       Owner:  pento
     Type:  defect (bug)           |      Status:  reopened
 Priority:  normal                 |   Milestone:  4.8.1
Component:  Emoji                  |     Version:  4.2
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch fixed-major  |     Focuses:
-----------------------------------+-----------------------

Comment (by pento):

 In [changeset:"41046"]:
 {{{
 #!CommitTicketReference repository="" revision="41046"
 Emoji: Store the results of the `emoji_url` and `emoji_ext` filters in
 statics.

 Previously, these filters were being run once per post, but the changes in
 [41043] caused them to be run once per emoji found.

 We will not stand idly by while this kind of unfair performance penalty is
 placed on the emoji literate. The filters are now run once only, emoji
 aficionados everywhere can rest easy, knowing their posts will be just as
 performant as their emoji-less cousins.

 Props ocean90 for noticing this severe oversight.
 See #35293.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35293#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list