[wp-trac] [WordPress Trac] #41056: WP-API JS Client: Settings is incorrectly registered as a collection
WordPress Trac
noreply at wordpress.org
Tue Jul 11 18:11:37 UTC 2017
#41056: WP-API JS Client: Settings is incorrectly registered as a collection
--------------------------------------+-----------------------------------
Reporter: adamsilverstein | Owner: adamsilverstein
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.8.1
Component: General | Version: 4.7
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses: javascript, rest-api
--------------------------------------+-----------------------------------
Comment (by kadamwhite):
@adamsilverstein Reviewed. In general it looks good; in lieu of a better
way to clearly explain how we want an endpoint to be treated, this seems
like a straightforward solution. One naming nitpick, I'd suggest
`modelEndpoints` instead of `singleModels` as I feel it's a little more
descriptive. If I see singleModels I would want to know what other kinds
of models there are, vs understanding that this is a model and not a
collection.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41056#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list