[wp-trac] [WordPress Trac] #31846: Using the browser's Back and Forward buttons doesn't update the media library

[WordPress Trac]

#31846: Using the browser's Back and Forward buttons doesn't update the media
library
-------------------------------------+------------------------------
 Reporter:  Faison                   |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Future Release
Component:  Media                    |     Version:  4.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+------------------------------

Comment (by adamsilverstein):

 Replying to [comment:29 afercia]:

 > Out of curiosity, I've checked what happens on the Theme installer and
 noticed the arrow navigation there uses `keyup` instead of `keydown` so
 the "continuous triggering" doesn't happen: users have to release the
 pressed key to trigger navigation. Wondering if also the attachments
 navigation should use `keyup` instead of `keydown`, also for consistency.

 I think you are right, we should change this input event to make it more
 consistent. Since we are no longer supporting older IE browsers, we can
 probably use [http://caniuse.com/#feat=input-event the input event]
 everywhere. I can create a separate ticket for this task.


 > P.S. not sure if the change to `Gruntfile.js` should stay in
 [attachment:31846.6.diff]

 Right, I will remove that - thanks for catching.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31846#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform