[wp-trac] [WordPress Trac] #40003: Error in pagination classes

[WordPress Trac]

#40003: Error in pagination classes
---------------------------------------+-----------------------
 Reporter:  SGr33n                     |       Owner:  afercia
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  4.9
Component:  Administration             |     Version:  3.4
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:
---------------------------------------+-----------------------
Changes (by afercia):

 * keywords:  has-patch => has-patch has-screenshots
 * owner:   => afercia
 * status:  new => assigned
 * milestone:  Awaiting Review => 4.9


Comment:

 The original intent to ''add'' the CSS class is pretty clear (because
 there is a space before the class). So I'd say either the space should be
 removed or the two strings be concatenated. I'm not sure this code is
 actually used anywhere in core. The `infinite_scroll` pagination arg is
 true just for the themes and theme-install list tables, and they're not
 used any longer (unless I'm missing something). However, custom tables
 added by plugins might use infinite scroll.

 The `pagination-links` CSS class shouldn't be removed in any case, because
 it is used for some styling in the responsive view.

 The theme install screen in WordPress 3.8, before the JS refactoring
 introduced in 3.9:

 [[Image(https://cldup.com/xDWbqf_eOf.jpeg)]]

 With JS off:

 [[Image(https://cldup.com/2BxnXmFMEW.jpeg)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40003#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform