[wp-trac] [WordPress Trac] #39800: current_item_{parent|ancestor} Not set for Post Type Archive Items

[WordPress Trac]

#39800: current_item_{parent|ancestor} Not set for Post Type Archive Items
---------------------------------------------+-----------------------
 Reporter:  mrwweb                           |       Owner:  welcher
     Type:  defect (bug)                     |      Status:  accepted
 Priority:  normal                           |   Milestone:  4.9
Component:  Menus                            |     Version:  4.7.2
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+-----------------------

Comment (by SergeyBiryukov):

 Replying to [comment:9 welcher]:
 > The only other change I'd make is to change the `in_array` method to use
 the strict parameter to avoid unexpected results.
 >
 > i.e `in_array( $_anc_id, $active_ancestor_item_ids , true )`

 The same check is already present in two other places in the function, so
 I think the new one should be non-strict as well for consistency. We could
 probably make them all strict, but let's do that in a new ticket :)

 Looks good to me otherwise.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39800#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform