[wp-trac] [WordPress Trac] #30120: Internationalize Hello Dolly
WordPress Trac
noreply at wordpress.org
Tue Jul 4 12:41:54 UTC 2017
#30120: Internationalize Hello Dolly
-------------------------+------------------------------
Reporter: Otto42 | Owner:
Type: enhancement | Status: reopened
Priority: normal | Milestone: Awaiting Review
Component: I18N | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
-------------------------+------------------------------
Changes (by SergeyBiryukov):
* status: closed => reopened
* resolution: duplicate =>
* milestone: => Awaiting Review
Comment:
This was brought up a couple months ago in several discussions on
#polyglots channel:
https://wordpress.slack.com/archives/C02RP50LK/p1493188906077157
https://wordpress.slack.com/archives/C02RP50LK/p1493806620691694
https://wordpress.slack.com/archives/C02RP50LK/p1495608311387916
https://wordpress.slack.com/archives/C02RP50LK/p1496213094682103
To summarize, Hello Dolly is a sample plugin that is supposed to follow
all the best practices. I18N is one of those, but the plugin currently
[https://translate.wordpress.org/projects/wp-plugins/hello-dolly displays
a warning on the translation page] due to a missing text domain:
> This plugin is not properly prepared for localization (View detailed
logs on Slack). If you would like to translate this plugin, please contact
the author.
This is less than ideal, a sample plugin shouldn't display any warnings.
The lyrics may not need a translation, but the description does. Each
plugin should have a `Text Domain:` header, and that's exactly what the
patch does.
#30353 was derailed into "remove Hello Dolly from core" and got closed as
wontfix, so let's reopen this one.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30120#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list