[wp-trac] [WordPress Trac] #41150: post_categories_meta_box() function should use a taxonomy label for "Most used" tab text

[WordPress Trac]

#41150: post_categories_meta_box() function should use a taxonomy label for "Most
used" tab text
-------------------------------------------------+------------------------
 Reporter:  jlambe                               |       Owner:  mdifelice
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9
Component:  Taxonomy                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch needs-docs  |     Focuses:  ui
-------------------------------------------------+------------------------
Changes (by boonebgorges):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch needs-
               docs


Comment:

 @mdifelice Thanks for the patch!

 > It is worth to note that some outputs on the post_categories_meta_box()
 function do not respect the late escaping policy neither escape at all.

 True, but we should be strict about this with all newly added strings.
 (Fixing the old ones should be a separate project, and will be complicated
 by backward compatibility concerns.)

 The approach in [attachment:41150.diff] looks good. Could you please add
 some documentation to `get_taxonomy_labes()` that describes the new
 string? See the function docblock for examples (both the `@since` and
 `@return` annotations), and see https://make.wordpress.org/core/handbook
 /best-practices/inline-documentation-standards/php/#1-1-parameters-that-
 are-arrays and https://make.wordpress.org/core/handbook/best-practices
 /inline-documentation-standards/php/#since-section-changelogs for more on
 our documentation standards. Thank you!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41150#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform