[wp-trac] [WordPress Trac] #39732: Allowing wp_update_comment() to return WP_Error

[WordPress Trac]

#39732: Allowing wp_update_comment() to return WP_Error
--------------------------------------+--------------------
 Reporter:  enrico.sorcinelli         |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  4.8
Component:  Comments                  |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+--------------------

Comment (by enrico.sorcinelli):

 Replying to [comment:3 gk.loveweb]:
 > Replying to [comment:2 swissspidy]:
 > > Two notes on the patch after a quick glance:
 > >
 > > * Coding standards need to be adhered to (e.g. curly braces)
 > > * The `// Check for WP_Error` comments are redundant. It's clear what
 `if ( is_wp_error( $updated ) )` does.
 >
 >
 > Please check my patch above, I have removed inline comment which is no
 longer needed or useful.

 In the fix of my patch you sent, it seems that you've removed all curly
 braces, not added where there was missing, as noticed

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39732#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform