[wp-trac] [WordPress Trac] #39516: Media grid upload errors display below the grid.

WordPress Trac noreply at wordpress.org
Fri Jan 27 19:38:32 UTC 2017

#39516: Media grid upload errors display below the grid.
 Reporter:  joemcgill         |       Owner:  afercia
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  4.7.3
Component:  Media             |     Version:  4.6
 Severity:  normal            |  Resolution:
 Keywords:  has-patch needs-  |     Focuses:  ui, accessibility, javascript
  testing                     |

Comment (by MatheusGimenez):

 Replying to [comment:12 adamsilverstein]:
 > @MatheusGimenez Thanks for the patch, it looks good!
 > A couple of code comments: for the model id check you should use a
 standards/javascript/#equality strict equality check]  and also switch the
 order to use [https://make.wordpress.org/core/handbook/best-practices
 /coding-standards/javascript/#yoda-conditions Yoda conditions].

 Hi, i applied the code standards in the last patch.

 Thanks for the feedback! :)

Ticket URL: <https://core.trac.wordpress.org/ticket/39516#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list