[wp-trac] [WordPress Trac] #39516: Media grid upload errors display below the grid.
WordPress Trac
noreply at wordpress.org
Fri Jan 27 19:03:47 UTC 2017
#39516: Media grid upload errors display below the grid.
------------------------------+--------------------------------------------
Reporter: joemcgill | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.7.3
Component: Media | Version: 4.6
Severity: normal | Resolution:
Keywords: has-patch needs- | Focuses: ui, accessibility, javascript
testing |
------------------------------+--------------------------------------------
Comment (by adamsilverstein):
@MatheusGimenez Thanks for the patch, it looks good!
A couple of code comments: for the model id check you should use a
[https://make.wordpress.org/core/handbook/best-practices/coding-
standards/javascript/#equality strict equality check] and also switch the
order to use [https://make.wordpress.org/core/handbook/best-practices
/coding-standards/javascript/#yoda-conditions Yoda conditions].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39516#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list