[wp-trac] [WordPress Trac] #38545: Add span element to get_the_archive_title()

WordPress Trac noreply at wordpress.org
Mon Jan 23 17:19:56 UTC 2017


#38545: Add span element to get_the_archive_title()
-------------------------+------------------------------
 Reporter:  Kaira        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Taxonomy     |     Version:  4.6.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------------

Comment (by theMikeD):

 I think the first patch is a better solution although I don't understand
 why `Author` was ignored.

 In @shireling patch I would suggest against the second span (the one
 around the content, what you call `archive-title`). The single span should
 be enough of a target. Or change it to

 `$format ='<span class="archive-label"><span>%s</span>%s</span>';`

 The other way to handle this would be to expand the filter to take (using
 @shireling patch for the var names) `$title, $format, $type,
 $title_classes, $name` or something along those lines. This way theme
 authors could wrap them as they see fit. This also dodges the what-would-
 certainly-be-an-endless discussion on what the class name should be
 called.

 As another observation, the : is problematic for me. Perhaps we can get
 rid of that altogether and add a CSS rule to add it back in? This way
 authors can determine if they want a : or - or whatever.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38545#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list