[wp-trac] [WordPress Trac] #39662: Color picker accessibility improvements

WordPress Trac noreply at wordpress.org
Sat Jan 21 16:00:17 UTC 2017


#39662: Color picker accessibility improvements
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Customize                |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  accessibility,
  patch                              |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  has-screenshots needs-patch => has-screenshots has-patch


Comment:

 [attachment:39662.diff] is just a first pass. There's still the need to
 check a few things, for example the notification container and the `hue`
 control. What the proposed patch does so far:
 - the toggle button is now a real button
 - thus, it needs just a click event: no need to handle the spacebar and
 enter key separately
 - the label element now contains just the label text and the input field
 - refactored the HTML to have a better overall structure
 - simplified the way elements visibility gets toggled
 - added an `aria-expanded` attribute on the toggle button
 - added `aria-label` attributes on the "Default/Clear" button
 - CSS clean-up

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39662#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list