[wp-trac] [WordPress Trac] #39199: Replace `is_super_admin()` checks with `manage_network` cap checks in wp-includes/option.php

WordPress Trac noreply at wordpress.org
Fri Jan 20 17:32:16 UTC 2017


#39199: Replace `is_super_admin()` checks with `manage_network` cap checks in wp-
includes/option.php
-----------------------------+------------------------
 Reporter:  chandrapatel     |       Owner:  flixos90
     Type:  enhancement      |      Status:  closed
 Priority:  normal           |   Milestone:  4.8
Component:  Role/Capability  |     Version:
 Severity:  normal           |  Resolution:  fixed
 Keywords:  has-patch        |     Focuses:  multisite
-----------------------------+------------------------
Changes (by flixos90):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39932"]:
 {{{
 #!CommitTicketReference repository="" revision="39932"
 Multisite: Do not check for `is_super_admin()` when trying to set user
 settings.

 The checks were introduced in [22256] to prevent user settings to be set
 for super admins that were not a member of the current site. However the
 latter should apply to any kind of user, so the `is_super_admin()` check
 is redundant. Furthermore, removing these checks is necessary for the
 ongoing effort to get rid of `is_super_admin()` checks in general.

 Props chandrapatel for initial patch.
 Fixes #39199. See #37616.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39199#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list