[wp-trac] [WordPress Trac] #39557: Twenty Seventeen: Wrong focus header image

[WordPress Trac]

#39557: Twenty Seventeen: Wrong focus header image
---------------------------+-------------------------
 Reporter:  Psychosopher   |       Owner:
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:
Component:  Bundled Theme  |     Version:  4.7
 Severity:  normal         |  Resolution:  worksforme
 Keywords:                 |     Focuses:
---------------------------+-------------------------
Changes (by davidakennedy):

 * status:  new => closed
 * resolution:   => worksforme
 * milestone:  Awaiting Review =>


Comment:

 @Psychosopher Perfect! Thank you for taking the time to make things
 clearer. That really helps!

 The reason you're seeing this isn't a bug. Twenty Seventeen uses a number
 of new CSS properties. Two of them are `@supports` and `object-fit`. In
 Twenty Seventeen, these are used in combination. Feature queries, or
 `@supports`, allows us to test if a browser can handle certain other CSS
 properties. In the theme, we use feature queries to test for `object-fit`
 in the header image/video area. Browsers that can use `object-fit` do so,
 and those that can't fall back to something else. `object-fit` lets us
 nicely fit and center images/videos in an area. So Firefox supports
 `object-fit` and it looks nice. Edge doesn't (yet), so it gets the
 fallback. More on that here: http://caniuse.com/#feat=object-fit

 So with that said, I'm going to close this since it's not a bug.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39557#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform