[wp-trac] [WordPress Trac] #39481: Twenty Seventeen: Allowing Google fonts in child themes
WordPress Trac
noreply at wordpress.org
Wed Jan 18 20:50:27 UTC 2017
#39481: Twenty Seventeen: Allowing Google fonts in child themes
---------------------------+----------------------
Reporter: tsvikas | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Bundled Theme | Version:
Severity: normal | Resolution: wontfix
Keywords: has-patch | Focuses:
---------------------------+----------------------
Changes (by davidakennedy):
* status: new => closed
* resolution: => wontfix
* milestone: Awaiting Review =>
Comment:
Hey @tsvikas! Thanks for the request, and welcome to Trac!
I would agree with @dd32 here. If you're looking to override and/or add
new fonts, you should do that in a new function and dequeue any styles if
you need to do that.
Especially with fonts, many have different subsets and weights that may
need to be handled, and it's easier to do that in a new function.
Also, with Twenty Seventeen, we went with less pluggable functions for
simplicity sake. See:
https://github.com/WordPress/twentyseventeen/pull/419 for some history.
With that said, I'm going to close this, since the preferred approach to
modify this function is already possible.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39481#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list