[wp-trac] [WordPress Trac] #39620: Improve PHP coding standards in class-automatic-upgrader-skin.php

[WordPress Trac]

#39620: Improve PHP coding standards in class-automatic-upgrader-skin.php
-----------------------------+----------------------
 Reporter:  carl-alberto     |       Owner:
     Type:  enhancement      |      Status:  closed
 Priority:  normal           |   Milestone:
Component:  Upgrade/Install  |     Version:  4.7.1
 Severity:  normal           |  Resolution:  wontfix
 Keywords:                   |     Focuses:
-----------------------------+----------------------
Changes (by dd32):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 Hi @carl-alberto

 Thanks for the patch, however I'm going to close this as a `wontfix` item.

 WordPress discourages code refactoring, which includes for coding
 standards, for maintenance and review burdens. Most of the WordPress files
 do not meet our coding standards in some form or another. Standards
 cleanup such as this is often done and accepted when the code in question
 is being modified/updated with fixes or enhancements though.

 See https://make.wordpress.org/core/handbook/contribute/code-refactoring/
 for more of our reasoning for rationale.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39620#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform