[wp-trac] [WordPress Trac] #39578: Enhancement for rest api comment controller create_item method to check for WP error

WordPress Trac noreply at wordpress.org
Tue Jan 17 15:45:37 UTC 2017


#39578: Enhancement for rest api comment controller create_item method to check for
WP error
-------------------------------------------------+-------------------------
 Reporter:  dspilka                              |       Owner:  rmccue
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  4.8
Component:  REST API                             |     Version:  4.7
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  needs-unit-tests good-first-bug      |     Focuses:  rest-api
  has-patch                                      |
-------------------------------------------------+-------------------------

Comment (by dspilka):

 Replying to [comment:4 rmccue]:
 > @dspilka Thanks for the patch :) Just to note: your indentation is off
 in the patch, but seeing how it's only 3 lines, not a huge issue here.
 Something to keep in mind for future patches though.

 Thanks @rmccue. Very happy to have my first WordPress patch. Would you
 mind pointing out how the indentation should be or how I can check it so I
 can get it right for my next patch? It seems to look like the others in my
 IDE, so I just want to make sure I understand it and know how to do it
 right. Thanks, Dan.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39578#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list