[wp-trac] [WordPress Trac] #31218: nav-menu.js menu item added event

[WordPress Trac]

#31218: nav-menu.js menu item added event
------------------------------------+------------------------------
 Reporter:  welcher                 |       Owner:  adamsilverstein
     Type:  enhancement             |      Status:  reviewing
 Priority:  normal                  |   Milestone:  4.8
Component:  Menus                   |     Version:  4.2
 Severity:  trivial                 |  Resolution:
 Keywords:  has-patch next-release  |     Focuses:  javascript
------------------------------------+------------------------------

Comment (by adamsilverstein):

 In [attachment:31218.10.diff]:
 * Switch the failure callback to assert that the expected number of tests
 had completed. No longer tries to clear the timeout.

 With the patch, all tests pass:
 [[Image(https://cl.ly/0v183o04342Q/Image%202017-01-16%20at%2011.53.51%20AM.png)]]

 Without the patch, the expected events don't fire and the fail check
 fails:
 [[Image(https://cl.ly/0F2c251h0t1M/Image%202017-01-16%20at%2011.54.26%20AM.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31218#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform