[wp-trac] [WordPress Trac] #39297: wrong return type in WP_User_Query::get_total()

[WordPress Trac]

#39297: wrong return type in WP_User_Query::get_total()
-------------------------------------+------------------
 Reporter:  runciters                |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.8
Component:  Users                    |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+------------------
Changes (by pento):

 * keywords:  has-patch => has-patch needs-refresh
 * version:  4.7 => 3.1
 * component:  Database => Users
 * milestone:  Awaiting Review => 4.8


Comment:

 Thank you for the ticket and patch, @runciters!

 The `$total_users` member is also supposed to be an `int`, so I think the
 better method would be to cast the value that `$wpdb->get_var()` returns
 as `int`.

 If you'd like to update the patch, we can get this sorted.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39297#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform