[wp-trac] [WordPress Trac] #39289: TinyMCE wpview: make inserting oEmbed previews smoother

[WordPress Trac]

#39289: TinyMCE wpview: make inserting oEmbed previews smoother
-------------------------------------+------------------
 Reporter:  azaozz                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.8
Component:  TinyMCE                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  ux-feedback needs-patch  |     Focuses:
-------------------------------------+------------------
Changes (by iseulde):

 * keywords:   => ux-feedback needs-patch


Comment:

 We talked a bit before about this and it seems the best way to do it is by
 adding '''JS regex''', '''types''', and maybe '''ratios/dimensions''' to
 the settings array, so we know immediately whether a URL is is embeddable
 or not (we don't want to show a placeholder for a URL if not) and we know
 what kind of placeholder to display. I think working with types could be
 interesting. With that information we could show a different type of
 placeholder for each type which can each have a default dimension. Maybe
 we can add the ratios/dimensions setting for more fine grained control.

 Another benefit of adding types is that it might be useful for UI to list
 the embed options. For this is, and maybe for better error messages as
 well, it could be useful to add the '''name of the service''' to the
 settings array as well. Cc @joen.

 Having both PHP and JS regex in the settings array is a bit weird, so I
 wonder if there's any way we can merge these two, especially since the
 regex are meant to be simple.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39289#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform