[wp-trac] [WordPress Trac] #39516: Media grid upload errors display below the grid.

[WordPress Trac]

#39516: Media grid upload errors display below the grid.
--------------------------+--------------------------------------------
 Reporter:  joemcgill     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  4.6
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui, accessibility, javascript
--------------------------+--------------------------------------------

Comment (by afercia):

 My bad 😬 There are good accessibility reasons to keep the current order
 in the source, see #36909. I'd recommend to don't revert the change.
 Looking for the simplest way to solve this bug, there's probably the need
 to distinguish two cases:

 - in the media modal: the sidebar is still displayed on the right (even if
 it's after the attachments in the source order) so, visually, everything
 works as expected (see screenshot below)
 - in the media Library though, the "sidebar" is displayed at the end of
 the attachments

 Error messages are handled by `wp.media.view.UploaderStatus` and
 `wp.media.view.UploaderStatusError` and displayed inside the "sidebar". I
 guess trying to change the way the `UploaderStatus` is tied to the sidebar
 wouldn't be so easy.

 As far as I see, in the Library view the "sidebar" is only used to display
 error messages so maybe one option could be to just create and place the
 sidebar conditionally:
 - if it's the Library view: create the sidebar before the attachments
 - otherwise: create the sidebar after the attachments

 Any thoughts welcome.

 Screenshot: error messages in the media modal sidebar:

 [[Image(https://cldup.com/xc4JU-50QX.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39516#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform