[wp-trac] [WordPress Trac] #39547: options-permalink.php throws incorrect "You should update..." notice on multisite

[WordPress Trac]

#39547: options-permalink.php throws incorrect "You should update..." notice on
multisite
----------------------------+-----------------------------
 Reporter:  boonebgorges    |      Owner:
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Permalinks      |    Version:  4.6
 Severity:  normal          |   Keywords:
  Focuses:  administration  |
----------------------------+-----------------------------
 Setup:

 1. Subdirectory multisite installation on Apache with mod_rewrite
 2. `/.htaccess/` and `/` should *not* be writable by the webserver
 3. On a secondary site (NOT blog 1), Dashboard > Options > Permalinks,
 ensure that you have pretty permalinks enabled (not index.php, not
 default)
 4. Click Save Changes without making any modifications
 5. You should see a green notice "You should update your .htaccess file
 now"

 Prior to #37380, saving existing settings would result in a success
 notice. However, #37380 just fixed a bug in the implementation of [37747],
 so I think the bug comes from #35936.

 Prior to [37747], the "You should update..." family of notices was never
 shown when `is_multisite()`. (Multisite routing is taken care of by
 WordPress, not by the webserver; WP's generated `RewriteBase` etc are
 incorrect in multisite.) I think that the fix here is to reintroduce the
 `is_multisite()` check.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39547>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform