[wp-trac] [WordPress Trac] #23120: There should be indication that widget settings have been saved
WordPress Trac
noreply at wordpress.org
Mon Jan 9 07:01:33 UTC 2017
#23120: There should be indication that widget settings have been saved
-------------------------------------------------+-------------------------
Reporter: jacopo.vip | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future
Component: Widgets | Release
Severity: normal | Version: 3.5
Keywords: has-patch needs-testing dev- | Resolution:
feedback | Focuses: ui
-------------------------------------------------+-------------------------
Comment (by westonruter):
I just came across this issue when integrating [JS
Widgets](https://github.com/xwp/wp-js-widgets) into the widgets admin
screen. The direction I took was analogous to what is done in the
customizer (surprise), where if the widget is not saved yet then the
button says “Save” as it does currently, but once the widget has been
updated (and the `widget-updated` event triggers) then the button becomes
`disabled` and the text changes to “Saved”. Upon making another change to
the widget, then the button becomes enabled again and the text returns to
“Save”. In the case of an HTTP error, then the enabled Save button just
will never turn to Saved. If the `WP_JS_Widget` failed a validation
constraint, then the button would remain “Save” but a validation
notification would appear in the control.
See [attachment:saved-button-state.png] and corresponding plugin commit:
https://github.com/xwp/wp-js-
widgets/commit/878b422e4c911bf80ce067ddd2a77cf110a7338b
--
Ticket URL: <https://core.trac.wordpress.org/ticket/23120#comment:46>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list