[wp-trac] [WordPress Trac] #39157: Feed returns 404 when there are no posts

[WordPress Trac]

#39157: Feed returns 404 when there are no posts
-------------------------------------------------+-------------------------
 Reporter:  pavelevap                            |       Owner:
     Type:  defect (bug)                         |  peterwilsoncc
 Priority:  high                                 |      Status:  assigned
Component:  Feeds                                |   Milestone:  4.7.2
 Severity:  normal                               |     Version:  4.7
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------

Comment (by stevenkword):

 Replying to [comment:20 peterwilsoncc]:
 > Looking at [attachment:39157.4.patch], I am not sure why the extra
 conditionals, `is_home_feed()` and `is_custom_feed()` are being introduced
 in this patch. I think new conditionals are best left to #20899.

 In 4.7 we killed all feeds that should not be rendered and missed the case
 for 'home feed on any site with zero posts' and for 'custom feeds' that
 don't rely on WP_Query.  This is an attempt to bring those feeds back and
 fix the regression.  Normally, I wouldn't be introducing new methods to
 WP_Query in a point release, but in this case, I think it's the right path
 forward and has the side effect of solving other problems moving forward.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39157#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform