[wp-trac] [WordPress Trac] #39109: Twenty Seventeen: starter content array needs a filter

[WordPress Trac]

#39109: Twenty Seventeen: starter content array needs a filter
------------------------------+--------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.7.1
Component:  Bundled Theme     |     Version:  4.7
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------
Changes (by celloexpressions):

 * keywords:  has-patch => has-patch commit


Comment:

 I'm going to mark this for commit for [attachment:39109.1.diff].

 Building a child theme, the first place I would look for a filter is in
 the parent theme, since I'd look there to see how I'd change what the
 parent registers. An exception could be if the child theme intends to
 completely replace the parent's starter content, in which case it would
 make sense to use a filter in core. I don't think that's particularly
 likely for starter content, though, and children will usually retain at
 least some of the parent functionality and the associated starter content.

 If nothing else, [attachment:39109.1.diff] improves Twenty Seventeen as an
 example implementation of starter content, particularly with the addition
 of inline documentation to explain how it's working (bringing this in line
 with the rest of the theme's inline documentation). The filter there
 doesn't hurt anything and we could add a core-side filter in the future as
 well if there's a need for that.

 There are other changes to Twenty Seventeen in 4.7.1 necessitating a
 release of the theme alongside core; we should get the theme-side changes
 in (and the docs changes, if nothing else) for 4.7.1 since the theme may
 not need an update for 4.7.2.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39109#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform