[wp-trac] [WordPress Trac] #36613: Browser back button doesn't work in Theme Browser

WordPress Trac noreply at wordpress.org
Tue Jan 3 20:52:22 UTC 2017

#36613: Browser back button doesn't work in Theme Browser
 Reporter:  dd32                     |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Themes                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
Changes (by adamsilverstein):

 * keywords:  needs-patch => has-patch needs-testing


 Themes: Fix issues when navigating browser history in the theme installer.
 Show correct theme and close previewer when backing out to install page.

 * Store a reference to the current preview when the theme installer
 preview view is opened
 * Add a listener to the preview so we can send it close events more easily
 * When navigating themes with next/back and adding the url to the browser
 history, use `replace: false` so we build up some history
 * When going back all the way to main install screen (the `sort` route),
 close the preview if open so view is back to the theme browser

 @dd32 can you please review and see if this works for you?

 Here is a screencast testing locally for the record:

Ticket URL: <https://core.trac.wordpress.org/ticket/36613#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list