[wp-trac] [WordPress Trac] #31101: get_page_of_comment returns wrong page if comments are ordered with newest first

[WordPress Trac]

#31101: get_page_of_comment returns wrong page if comments are ordered with newest
first
-------------------------------------+--------------------------
 Reporter:  pajtai                   |       Owner:  rachelbaker
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  4.7
Component:  Comments                 |     Version:  4.1
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------------

Comment (by boonebgorges):

 In [changeset:"39664"]:
 {{{
 #!CommitTicketReference repository="" revision="39664"
 Ignore the 'comment_order' setting when determining comment pagination.

 [38740] incorrectly introduced logic that changed a comment's page when
 'comment_order' was set to 'desc'. This is in violation of the design
 of the comment pagination system: a comment's page is designed not to
 change when 'comment_order' or 'default_comment_page' are changed.
 See #31101.

 Merges [39663] to the 4.7 branch.

 Props rachelbaker.
 Fixes #39280.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31101#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform