[wp-trac] [WordPress Trac] #39983: Consider to don't use the CSS class button-link for controls that don't look like links

[WordPress Trac]

#39983: Consider to don't use the CSS class button-link for controls that don't
look like links
----------------------------+-----------------------------
 Reporter:  afercia         |      Owner:
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Administration  |    Version:
 Severity:  normal          |   Keywords:  has-screenshots
  Focuses:  ui              |
----------------------------+-----------------------------
 After [40059] the CSS class `button-link` uses `text-align: left` by
 default. This makes sense, since this class should be used to make buttons
 look like links. Browsers default stylesheets make text within buttons
 centered, so there's the need to make the text explicitly left aligned to
 prevent some edge cases, see for example #38712.

 However, now the media modal "X" close button text is misplaced. Worth
 checking if the same thing happens for other buttons too. In these cases,
 text should be centered:

 [[Image(https://cldup.com/pmFlhBxwZV.png)]]

 It's a minor visual glitch and can be easily fixed. Ideally, these buttons
 shouldn't use the `button-link` class at all. They'd need just some reset
 of the default buttons CSS properties.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39983>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform