[wp-trac] [WordPress Trac] #39367: Don't no-op $user_id in test suite's wp_set_auth_cookie()

[WordPress Trac]

#39367: Don't no-op $user_id in test suite's wp_set_auth_cookie()
------------------------------+--------------------
 Reporter:  danielbachhuber   |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.7.4
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------

Comment (by johnbillion):

 Here's my proposal.

 For trunk and the 4.7 branch:

 * Remove the overridden `wp_set_auth_cookie()` and
 `wp_clear_auth_cookie()` functions from the test suite.

 For the 4.7 branch only:

 * Remove the tests which use
 `WP_Test_REST_Users_Controller::verify_user_roundtrip()`, as these are the
 tests which result in the "headers already sent" error unless the auth
 cookie functions are overridden.

 For trunk:

 * Implement [attachment:39367.diff].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39367#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform