[wp-trac] [WordPress Trac] #39441: Improve the Settings API for accessibility and ease of use.

[WordPress Trac]

#39441: Improve the Settings API for accessibility and ease of use.
-------------------------------------+-------------------------------------
 Reporter:  flixos90                 |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Plugins                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  settings-api has-patch   |     Focuses:  accessibility,
  2nd-opinion                        |  administration
-------------------------------------+-------------------------------------

Comment (by flixos90):

 @afercia

 1. I generally agree that an empty `$title` should be disallowed, on the
 other hand I'm not sure how to handle this in terms of BC. Also I think we
 should try to make all the default form controls accessible by default,
 but if the user explicitly wants to have it in a different way, I think it
 should be possible. For example, even with a title it is still possible to
 not print a label (only if you really do not want it) by explicitly
 setting the `label_for` argument to an empty string. I think that should
 be acceptable since it would otherwise restrict developers too much (if
 they would like to display the label manually for example, let's say in
 `before` or something like that).
 2. Was that incorrect somewhere in the patch? I thought it uses explicit
 association all over.
 4. Right, that is a bug in [attachment:39441.implementation.diff] specific
 to these fields. I'm generally aware of this and considered it in the main
 patches. When using the default radio group callback, that text "Date
 Format" would automatically be printed as a fieldset. Since I use a custom
 callback for these fields though, I need to add the `fieldset => true`
 argument manually, which I overlooked. So I'll update that later as well.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39441#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform