[wp-trac] [WordPress Trac] #27555: Make tag post meta box more accessible

[WordPress Trac]

#27555: Make tag post meta box more accessible
------------------------------+----------------------------
 Reporter:  joedolson         |       Owner:  joedolson
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  4.7
Component:  Editor            |     Version:  3.0
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  accessibility
------------------------------+----------------------------

Comment (by cyclic):

 This change includes removing "return false" from the click handler on $(
 '.tagcloud' ):

 https://github.com/WordPress/WordPress/commit/5c555e5d10d57c69b41c2eb5e5fae383805cef88
 #diff-9d47a87c240c1d10701cd6a02b28aa1bL199

 Previously an anchor tag with that class could have any href and it
 wouldn't make a difference. Now the href must be "javascript: return
 false" to accommodate the fact that the handler no longer returns false.
 Is that a bug or is there a reason it was removed?

 The specific case I'm looking at is in the bp-event-organiser plugin which
 relies on the tags-box library:

 wp_enqueue_script:
 https://github.com/cuny-academic-commons/bp-event-
 organiser/blob/master/includes/wp-frontend-admin-screen/wp-frontend-admin-
 screen.php#L448

 the markup which includes the class "tagcloud" with an href of
 "#titlediv", which the browser obeys after upgrading WP to include the new
 tags-box (previously the href was ignored due to "return false"):
 https://github.com/cuny-academic-commons/bp-event-
 organiser/blob/master/includes/wp-frontend-admin-screen/abstraction-
 metabox.php#L476

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27555#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform