[wp-trac] [WordPress Trac] #32378: Image Uploads automatically puts "Olympus Digital Camera" as caption
WordPress Trac
noreply at wordpress.org
Tue Feb 21 22:47:12 UTC 2017
#32378: Image Uploads automatically puts "Olympus Digital Camera" as caption
-------------------------------------------------+-------------------------
Reporter: vparkhere | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future
Component: Media | Release
Severity: normal | Version: 4.2
Keywords: dev-feedback needs-unit-tests | Resolution:
needs-patch | Focuses:
-------------------------------------------------+-------------------------
Comment (by dmsnell):
The latest patch
(https://core.trac.wordpress.org/attachment/ticket/32378/32378-2.patch) I
just uploaded makes some big changes to the scope of this ticket: in
addition to simply replacing the Olympus camera defaults it provides a
generalized system for replacing unwanted image metadata, as requested by
@wonderboymusic.
The new patch is much more complicated than the original one and I could
just as easily see the extensibility coming in from adding more filters on
`wp_read_image_metadata` instead of this new system. However, the new
`image_metadata_substitute_defaults()` ''does'' provide a more straight-
forward way of adding new substitutions that should hopefully be safer and
easier for people to find and use.
There are no tests on this patch yet and I haven't even tested the code to
see if it works. My goal in submitting it is to garner feedback on the
implementation. The heart of the filter is testable outside of the
WordPress environment and it should be trivial to add tests once we know
if that's what we want to build.
I agree with what @swissspidy brought up: users shouldn't need to know
that they have to look for a plugin in order to fix this and the behavior
without a fix is likely to look like we misread the image data. My
argument in favor of "fixing" this is that the information provided by
default doesn't semantically match the EXIF fields it's stored in.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/32378#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list