[wp-trac] [WordPress Trac] #39564: Notice: Undefined index: item_spacing in /var/www/html/wordpress/wp-includes/class-walker-page.php on line 106
WordPress Trac
noreply at wordpress.org
Mon Feb 20 21:55:10 UTC 2017
#39564: Notice: Undefined index: item_spacing in /var/www/html/wordpress/wp-
includes/class-walker-page.php on line 106
------------------------------------------+-----------------------
Reporter: jrswgtr | Owner: dd32
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.7.3
Component: Menus | Version: 4.7
Severity: normal | Resolution:
Keywords: has-patch commit fixed-major | Focuses:
------------------------------------------+-----------------------
Comment (by peterwilsoncc):
Replying to [comment:15 dd32]:
> @peterwilsoncc in [39949] I note that the logic has now changed from the
4.6 behaviour in the event that the `item_spacing` arg is not provided -
it'll default to `discard` in that case now.
>
> Should this have been `if ( ! isset(...) || 'preserve' ...`?
That's a good catch.
It looks like the behaviour has changed when the walker is called directly
rather than via `wp_list_pages()` and related functions. I'm inclined to
leave it as it's an edge case and, arguably, ill advised.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39564#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list