[wp-trac] [WordPress Trac] #39879: wp_get_sites() with a false limit no longer returns all sites

[WordPress Trac]

#39879: wp_get_sites() with a false limit no longer returns all sites
--------------------------------------+------------------------------
 Reporter:  iandunn                   |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Networks and Sites        |     Version:  4.6
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+------------------------------
Changes (by iandunn):

 * keywords:   => has-patch has-unit-tests


Comment:

 `39879.1.diff` is a first pass at a test and fix. I haven't had time to
 test it thoroughly, though, so I'd appreciate more eyes on it.

 A new test wasn't actually required here; the existing tests would have
 caught this bug if a sufficient number of sites existed in the database.
 Creating that many sites introduces a performance issue to the test suite,
 though. The time required to run the `wp-get-site` group increases from
 `~10` seconds to `~50`.

 I don't have a good solution to that right now; does anyone have any
 ideas?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39879#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform