[wp-trac] [WordPress Trac] #39445: Add class_exists() check before defining the PasswordHash class

[WordPress Trac]

#39445: Add class_exists() check before defining the PasswordHash class
---------------------------+--------------------
 Reporter:  DavidAnderson  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.7.3
Component:  General        |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+--------------------

Comment (by aaroncampbell):

 Replying to [comment:3 dd32]:
 > Alternative: Revert [38371] in trunk/4.8, switch to `require_once()` in
 `wp-settings.php` for 4.7 to avoid extra file churn in the minor, but also
 avoid this scenario.
 >
 > The con of changing this back, and even more of delaying it until 4.8,
 is that if anyone who between 4.7.0 and $release who expects the class to
 exist will hit a fatal. I can't see a reason for most users to need it.

 I'm with @dd32 here (even though I understand the desire to clean things
 up like this). Unless @wonderboymusic has reasoning for this beyond
 "cleaner files", I'd say we should just put it back how it was. I get that
 it was required in a handful of places, but that's because it was only
 used in a handful of places.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39445#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform