[wp-trac] [WordPress Trac] #32417: Add new core media widget

[WordPress Trac]

#32417: Add new core media widget
----------------------------------------+---------------------------------
 Reporter:  melchoyce                   |       Owner:  melchoyce
     Type:  feature request             |      Status:  assigned
 Priority:  normal                      |   Milestone:  4.8
Component:  Widgets                     |     Version:  4.3
 Severity:  normal                      |  Resolution:
 Keywords:  needs-unit-tests has-patch  |     Focuses:  ui, administration
----------------------------------------+---------------------------------

Comment (by melchoyce):

 After reviewing this ticket again, I think it's a good example of scope
 creep and overthinking a feature. I stalled it out by talking about adding
 a media button to the text widget (which I still think is a good idea) We
 even recently prioritized this over the media widget in a
 [https://wordpress.slack.com/archives/core-customize/p1485198055002330
 Customizer meeting], but I actually think we should launch a standalone
 media widget with the work started here. I prioritized getting
 '''everything''' in over getting '''something''' in and I'm starting to
 see that was the wrong approach. Apologies.

 So, let's review where we're at and the pros/cons of releasing a v1:

 '''Pros''':
 - We'll get something out sooner, maybe even in a point release?
 - The most recent patch is a good v1. It is better than what we have now,
 which is nothing.
 - It also fits within our goal of "quick wins" for Customization in the
 next couple of months.

 '''Cons''':
 - The widget won't include galleries, playlists, or captions in the first
 release.
 - The widget won't include adding an image, video, or audio file from an
 external URL in the first release.

 I think it's okay to keep the scope small for now, and worry about
 galleries, playlists, and captions once the work in #35760 has moved
 forward more.

 I reviewed the current patch and took some screenshots here:
 https://cloudup.com/cPOxeaSOdpM

 While reviewing, here were some improvements I jotted down:
 - When you add a new image, video, or audio file, it should display in the
 widget above the "Select media" button, not below it. (See: Header Media)
 - "Select media" should change to "change media" once you've make your
 initial media selection. (See: Site Icons)
 - "Use as widget" still isn't ideal. Maybe "add to widget" or "add to
 sidebar?"
 - When you add an image to the widget, the widget's title in the widget
 meta box seems to be using the image title, rather than the title entered
 into the title field within the widget. This doesn't happen to audio or
 video. (You can see this in the image widget screenshot)
 - "Open link in a new tab or window" doesn't make sense for something
 without a link. This checkbox should probably only appear within the media
 modal itself, if you've opted to add a link to the image or link directly
 to the video or audio file instead of embedding. (Brought up in
 https://core.trac.wordpress.org/ticket/32417#comment:30).
 - Downloading seems to be on by default for audio and video — we should
 probably turn this off entirely. When I add media to my sidebar, I don't
 expect to provide an easy way to download that media (though I understand
 it's possible).
 - Videos aren't responsive by default and break the layout. Can we do
 something in core to make them display within the confines of the widget
 in which they are being displayed?
 - Video controls overlay the video itself, and don't seem to disappear
 after a while. They should display underneath the video. Is this how core
 handles video embeds or just a quirk with the widget?
 - Can we remove "caption" from the media modal since we can't display
 captions yet?
 - Maybe a bug: When uploading an audio file, I changed its display
 "embedded media player" to "link to media file." I added the file, then
 clicked into the media modal again, and the dropdown swapped back to
 "embedded media player."
 - The widget says "add an image, gallery, video, or audio to your
 sidebar," but the current iteration can't support a gallery yet. We should
 exclude gallery from this text.
 - Let's update the widget's description to be something more like "Display
 media (image, video, or audio) in your sidebar" or "Display media such as
 images, video, or audio in your sidebar," so it's easier to search for
 within the Customizer widget panel.

 Let's get this moving again. Thanks to everyone who's been participating
 over the past 21 months.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32417#comment:95>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform