[wp-trac] [WordPress Trac] #39774: php 7.1 media uploader bug

[WordPress Trac]

#39774: php 7.1 media uploader bug
--------------------------+--------------------
 Reporter:  drrobotnik    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.7.3
Component:  Upload        |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------
Changes (by SergeyBiryukov):

 * keywords:   => has-patch


Comment:

 Ah, I was wrong, we can't set `$number` to `0`, because it needs to be an
 empty string on first iteration. Otherwise, it causes the infinite loop
 issue that you experienced.

 [attachment:functions.diff] works fine, I'd just like to make the type
 casting explicit just in case.

 [attachment:39774.patch] also makes it more consistent with the preceding
 block.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39774#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform