[wp-trac] [WordPress Trac] #42998: Custom HTML Widget uses widget_text twice in markup

WordPress Trac noreply at wordpress.org
Fri Dec 29 16:34:45 UTC 2017


#42998: Custom HTML Widget uses widget_text twice in markup
--------------------------+-----------------------------
 Reporter:  dreamwhisper  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Widgets       |    Version:  4.8.1
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 In https://core.trac.wordpress.org/changeset/41117, classes were added to
 the Custom HTML Widget to apply the same styling as the Text Widget in
 themes.

 However, there's an extra widget_text class that isn't in the Text Widget.

 Example markup:

 Custom HTML widget - The widget_text is on the section and the widget-wrap
 div.
 {{{
 <section id="custom_html-2" class="widget_text widget widget_custom_html">
 <div class="widget_text widget-wrap">
 <h3 class="widgettitle widget-title">Custom HTML</h3>
 <div class="textwidget custom-html-widget">
 Custom HTML Content
 </div>
 </div>
 </section>
 }}}

 Text Widget - The widget-wrap div has only that class.
 {{{
 <section id="text-2" class="widget widget_text">
 <div class="widget-wrap">
 <h3 class="widgettitle widget-title">Text Widget</h3>
 <div class="textwidget">
 <p>Text Widget Content</p>
 </div>
 </div>
 </section>
 }}}

 As a result, any theme that has styled widget_text may have unintended
 styling issues.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42998>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list