[wp-trac] [WordPress Trac] #42985: No error message returned by empty wp-login.php form

WordPress Trac noreply at wordpress.org
Fri Dec 29 13:21:15 UTC 2017


#42985: No error message returned by empty wp-login.php form
-----------------------------------------+--------------------------------
 Reporter:  zergling81                   |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Login and Registration       |     Version:  2.5
 Severity:  normal                       |  Resolution:
 Keywords:  needs-patch has-screenshots  |     Focuses:  ui, accessibility
-----------------------------------------+--------------------------------

Comment (by birgire):

 I wonder if the logic for empty username and empty password should be
 moved out of {{{wp_signon()}}}, back to the {{{wp-login.php}}}, for better
 flexibility.

 I checked version 2.3 mentioned by @afercia  and there it seems to be
 handled in {{{wp-login.php}}} with:

 {{{
 if ( $_POST && empty( $user_login ) )
     $errors['user_login'] = __('<strong>ERROR</strong>: The username field
 is empty.');
 if ( $_POST && empty( $user_pass ) )
     $errors['user_pass'] = __('<strong>ERROR</strong>: The password field
 is empty.');

 }}}

 before the {{{login_header(__('Login'));}}}

 See [https://core.trac.wordpress.org/browser/tags/2.3/wp-login.php#L335
 source].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42985#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list