[wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options

[WordPress Trac]

#37181: Use metadata api in *_network_options
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.0
Component:  Networks and Sites                   |     Version:  4.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch ms-roadmap dev-feedback    |     Focuses:  multisite
  has-unit-tests                                 |
-------------------------------------------------+-------------------------

Comment (by jeremyfelt):

 Thanks for your work on this, @spacedmonkey.

 [attachment:37181.8.diff] is updated against current trunk to account for
 the changes in [42343].

 A couple notes so far:

 * We're switching from `site-options` to `site_meta` as the cache group,
 but still using `site-options` for a handful of other
 things—`current_network`, `networks_have_paths`, etc... This is probably
 okay because we weren't ever storing those "options" in the DB.
 * We'll want to make sure once this is in that external object cache drop-
 ins are aware/updated with the new global cache group.
 * In general, I think our network option tests could use some work. For
 something like this we should write some more tests that rely on an
 external object cache.
 * Is it possible that anyone is relying on `notoptions` right now for some
 reason? May need to do some digging through plugins briefly to see if
 anything stands out.

 I'll spend some more time with this and think through the testing a bit
 more.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37181#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform