[wp-trac] [WordPress Trac] #42937: Success Message should display on insertion of new category in Taxonomy page

WordPress Trac noreply at wordpress.org
Tue Dec 19 15:16:13 UTC 2017


#42937: Success Message should display on insertion of new category in Taxonomy
page
----------------------------------------+------------------------------
 Reporter:  manishamakhija              |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Taxonomy                    |     Version:  4.9.1
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+------------------------------

Comment (by birgire):

 Hi @manishamakhija, welcome to WordPress trac.

 This looks like a good improvement, I recall adding tags/categories and
 not being sure if it was added or not.

 I noticed that the following string in [attachment:42937.patch] is not
 translatable:

 {{{
 $message = 'New '. $tax->labels->singular_name . ' created successfully';

 }}}

 Suggestion:

 {{{
 $message = sprintf( __( 'New %s created successfully' ),
 $tax->labels->singular_name );

 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42937#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list