[wp-trac] [WordPress Trac] #16979: Extra hooks needed in comment process
WordPress Trac
noreply at wordpress.org
Mon Dec 11 20:04:44 UTC 2017
#16979: Extra hooks needed in comment process
-------------------------------------------------+-------------------------
Reporter: dd32 | Owner: jpurdy647
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.0
Component: Comments | Version:
Severity: normal | Resolution:
Keywords: good-first-bug has-patch dev- | Focuses:
feedback |
-------------------------------------------------+-------------------------
Changes (by boonebgorges):
* keywords: good-first-bug has-patch => good-first-bug has-patch dev-
feedback
* milestone: Future Release => 5.0
Comment:
[attachment:16979.2.diff] is a modification of @jpurdy647's previous
patch. It renames the filter 'allow_empty_comment', which I think is more
descriptive of what's really happening here. (I know the term "valid" is
used in the `WP_Error` string, but it feels confusing to me in this
context, since "valid" could mean any number of things.) I've also changed
the position of the filter a bit so that it can receive the `$commentdata`
for more fine-grained filtering.
Do others have thoughts about how specific this filter ought to be?
("empty" vs "valid")
--
Ticket URL: <https://core.trac.wordpress.org/ticket/16979#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list