[wp-trac] [WordPress Trac] #42873: Customize: Allow themes to be installed when SFTP credentials required

[WordPress Trac]

#42873: Customize: Allow themes to be installed when SFTP credentials required
------------------------------+--------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.9.2
Component:  Customize         |     Version:  4.9
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------
Changes (by westonruter):

 * keywords:   => has-patch


Old description:

> Split out from #42184.
>
> Next steps:
> - Revert [41997]
> - Use [attachment:42184.2.diff]
> - Fix the two known bugs: incorrect labels after cancelling the modal,
> and fix broken buttons after cancelling the modal
>
> Note that with [attachment:42184.2.diff], SFTP appears to work as
> expected. The only issues are with canceling the modal, which happens
> much more in testing than in practice. [41997] seems like an overreaction
> to the minor bugs that we need to track down with that, which may seem
> worse than they are because they are more apparent in a testing workflow
> than in real usage. Either way, the fixes for that should not be
> particularly difficult. I'm not planning on working on this issue
> further, so someone else can take it on.

New description:

 Split out from #42184.

 Next steps:
 - Revert [41997]
 - Use
 [https://core.trac.wordpress.org/attachment/ticket/42184/42184.2.diff
 42184.2.diff]
 - Fix the two known bugs: incorrect labels after cancelling the modal, and
 fix broken buttons after cancelling the modal

 Note that with
 [https://core.trac.wordpress.org/attachment/ticket/42184/42184.2.diff
 42184.2.diff], SFTP appears to work as expected. The only issues are with
 canceling the modal, which happens much more in testing than in practice.
 [41997] seems like an overreaction to the minor bugs that we need to track
 down with that, which may seem worse than they are because they are more
 apparent in a testing workflow than in real usage. Either way, the fixes
 for that should not be particularly difficult. I'm not planning on working
 on this issue further, so someone else can take it on.

--

Comment:

 See patch
 https://core.trac.wordpress.org/attachment/ticket/42184/42184.2.diff

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42873#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform