[wp-trac] [WordPress Trac] #42852: Add new user: new password not generated when reopening Show Password

[WordPress Trac]

#42852: Add new user: new password not generated when reopening Show Password
--------------------------+-------------------------
 Reporter:  afercia       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.0
Component:  Users         |     Version:  4.7
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  javascript
--------------------------+-------------------------

Comment (by afercia):

 I think the root cause of the problem is some ambiguity in the controls
 names, as pointed out in #32979, together with the intent to automate some
 behaviors in a smart way. Sometimes trying to be smart can be confusing
 for users, as it often assumes one specific workflow while users might
 have a different intent.

 Any change to this UI should try to respect the original intent of the
 feature, see [https://make.wordpress.org/core/2015/05/11/the-plan-for-
 passwords/ The Plan for Passwords]. Also, the ability for users to
 generate new passwords added in #33450 should be preserver, but I think it
 shouldn't happen when clicking "Cancel".

 I'd propose to try to keep things simple, and make the UI more transparent
 to users.
 - rename the "Generate Password" and "Show password" buttons to "Set New
 Password"
 - make the button always generate a new password each time it gets
 pressed: the new button text will indicate exactly what the button does
 (apart from opening the form)
 - don't move focus or select the password programmatically: this is often
 based on an assumption on a specific workflow and might not be what users
 want, not to mention is confusing for assistive technologies users
 - make the "Cancel" button just... "Cancel" :) keeping the form open and
 just clearing the fields would make very clear to users what's going on

 /cc @markjaquith @helen @adamsilverstein @SergeyBiryukov

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42852#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform