[wp-trac] [WordPress Trac] #42852: Add new user: new password not generated when reopening Show Password

[WordPress Trac]

#42852: Add new user: new password not generated when reopening Show Password
--------------------------+-------------------------
 Reporter:  afercia       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  5.0
Component:  Users         |    Version:  4.7
 Severity:  normal        |   Keywords:  needs-patch
  Focuses:  javascript    |
--------------------------+-------------------------
 Noticed while working on #42749: After [38494], see also [34312], [33766],
 [33079], and [32589], in the "Add new user" screen a new password is not
 displayed when clicking "Show Password", then "Cancel", then "Show
 Password" again.

 In WordPress 4.6:
 - go in the "Add new user" screen (user-new.php)
 - click "Show Password"
 - observe the generated password
 - click "Cancel": the form closes
 - click "Show Password" again
 - observe there's a new generated password displayed

 This matched the behavior in the "Your profile" screen (profile.php.)

 Repeat the above steps in WordPress 4.7 or more recent version:
 - go in the "Add new user" screen (user-new.php)
 - click "Show Password"
 - observe the generated password
 - click "Cancel": the form closes
 - click "Show Password" again
 - the password field is empty

 At this point, there's no way to generate a new password other than
 reloading the page. Additionally:
 - a real password is actually generated but is not displayed in its "non-
 masked" form
 - the password field looks empty but the strength indicator says "Strong"
 - clicking "Hide" shows the real password field filled with dots:
 confusing for users, since the other field is empty

 Following the argumentations on the related tickets #33419 and #37902, the
 implemented changes make sense. However, there's an unintended
 consequence: the real password field `$pass1` is filled up while its
 visual representation `$pass1Text` is empty.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42852>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform