[wp-trac] [WordPress Trac] #42811: Run the PHP 5.2 Travis job with the MySQL Extension

WordPress Trac noreply at wordpress.org
Fri Dec 8 03:46:00 UTC 2017


#42811: Run the PHP 5.2 Travis job with the MySQL Extension
------------------------------+------------------
 Reporter:  dd32              |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+------------------

Old description:

> I just noticed that the PHP 5.2 job is running with MySQLi (which I
> didn't even realise was possible).
>
> That ultimately means we have no automated testing which is testing the
> `mysqli_*` functions in `$wpdb` which is used for PHP 5.2~5.4 by default.
>
> The attached patch uses `WP_USE_EXT_MYSQL` to force it to use the MySQL
> extension for the PHP 5.2 job, I've tested this on [https://travis-
> ci.org/dd32/wordpress-develop/jobs/312272686 my own travis account] and
> it passes as expected, with the only change being an additional skipped
> test (which requires mysqli).

New description:

 I just noticed that the PHP 5.2 job is running with MySQLi (which I didn't
 even realise was possible).

 That ultimately means we have no automated testing which is testing the
 `mysql_*` functions in `$wpdb` which is used for PHP 5.2~5.4 by default.

 The attached patch uses `WP_USE_EXT_MYSQL` to force it to use the MySQL
 extension for the PHP 5.2 job, I've tested this on [https://travis-
 ci.org/dd32/wordpress-develop/jobs/312272686 my own travis account] and it
 passes as expected, with the only change being an additional skipped test
 (which requires mysqli).

--

Comment (by dd32):

 Just noticed I incorrectly referenced `mysqli_*` functions instead of
 `mysql_*` functions :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42811#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list